Addressing issue 9 - partial fix for moving the models to separate class #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dont add mentions if they exceed character limit
…it-fix length fix
shrayasr
requested changes
Dec 6, 2017
|
Tweetinvi api has also one configuration.cs file so accessing thehexbot.Models.Configuration as config. In C# two classes having same name with different name space, we have to explicitly mention the full namespace and class name |
|
and also renamed models to Models |
shrayasr
reviewed
Jan 16, 2018
| @@ -8,7 +8,7 @@ | |||
| using Tweetinvi; | |||
| using Tweetinvi.Parameters; | |||
| using Tweetinvi.Models; | |||
|
|
|||
| using config = thehexbot.models; | |||
There was a problem hiding this comment.
why this like? A simple using thehexbot.Models should allow us to use Configuration right? Why config.Configuration? It seems redundant
|
Tweetinvi api has also one configuration.cs file so accessing thehexbot.Models.Configuration as config. In C# two classes having same name with different name space, we have to explicitly mention the full namespace and class name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request is part of addressing issue 9. I have moved the models to separate classes, if it agrees with your coding conventions, approve the pull request, also i will start moving the core logic to separate classes
Thanks
Balaji