Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade many dependencies #164

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

papegaaij
Copy link

@papegaaij papegaaij commented Mar 18, 2022

This PR upgrades many dependencies to the latest versions. This includes the upgrades to maven 3.8.5 and gradle 7.1.1.

I did have issues with one testcase: PackageDirectoriesWithClassesTestCase.packageWar, so I chose to Ignore that test for now. Also, the maven-invoker-plugin refuses to install the required artifacts for me.

edit
I've updated the PR to maven 3.9.0

@petrberan
Copy link
Member

Hi @papegaaij , sorry for the late ping, I've recently taken over the Shrinkwrap project and I'm slowing chewing through the PRs. Would you be interested in updating this PR or should we recreate it ourselves?

@papegaaij
Copy link
Author

Hi @petrberan , great to see this project is being revived. Many thanks for your efforts so far! Given the amount of changes you've already made that conflict with this PR, I think it's not worth the effort to update this PR. You may want to use it as reference to help in the upgrade for some of the components, but I see you've already upgraded most of them.

Given the amount of changes already in master, when do you expect to release a new version? Maybe this should be a 4.0 and it might be a good idea to release a beta first. We'll be happy to help in testing it.

@petrberan
Copy link
Member

petrberan commented Aug 13, 2024

Thank you @papegaaij . I'll leave this PR open for now, I've filed a JIRA ticket that will check this PR and see if we can reuse some of the parts here. I'll close this PR afterwards.

As for the new versions, I'm reserving the next major for new JDK. So far we've got only some bugfixes and dependency upgrades, so I would like to release a new minor soon. There are 2 new dependencies failing CI, but I expect those could be resolved soon.

@petrberan
Copy link
Member

Hi @papegaaij , the 3.3.1 has just been released. Feel free to upgrade your projects and provide any feedback 👍

@papegaaij
Copy link
Author

@petrberan thanks for the heads-up. I'll give it a try tomorrow. Btw, I don't see the artifacts at maven central yet.

@papegaaij
Copy link
Author

I did some testing, and 3.3.1 seems to work fine for us. Thanks for the work!

@petrberan
Copy link
Member

That's good news, glad to hear that @papegaaij . Sorry about the artifact, we seem to have a problem with our company Nexus syncing with Maven central. Hopefully next week it'll be resolved

@papegaaij
Copy link
Author

They are on central now. So, the sync does work, but it seems to take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants