Improve the inline/columnar combination #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix again the span computation, make so the compact representation does not behave weirdly when it needs to go columnar in subqueries.
lu-zero
changed the title
|
@bartlomieju if you have time to give it a try would be great. Also are we all happy with the options available? |
|
@lu-zero thanks, we tried it on our end and it seems to work fine. So we'd definitely be interested in shipping it in Deno v2.2 |
|
There is potentially one issue on formatting WITH but I hadn't had time to distill a test and a fix for it yet. It shouldn't block this set |
shssoichiro
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix again the span computation, make so the compact representation does not behave weirdly when it needs to go columnar in subqueries.
Now it is really getting closer to ideal if somebody wants a compact representation.
Yet to be done:
* JOINa top level keyword or not.