Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using exception handling for errors. #4

Open
wants to merge 61 commits into
base: master
Choose a base branch
from
Open

Switch to using exception handling for errors. #4

wants to merge 61 commits into from

Conversation

KendallHopkins
Copy link

I know this will break backward compatibility but IMO it's very important to force programmers to handle curl errors, instead of passively handling them (via ->error()). It also removes the possible case where a person tries to treat the output of request as an object causing a fatal error to be triggered.

bjeavons and others added 30 commits January 28, 2011 10:51
@bjeavons
Support multipart form POST requests.
0e27208
@hamstar
Added get_request_options() to allow checking the options set in curl
88938a0
@jrivero
default values
293d5f3
@KendallHopkins
Use exceptions for the error handling.
03fab04
@KendallHopkins
Use a better and sorted list of exception.
3a0cc7d
@KendallHopkins
Include error message in throw exception.
9f6d38e
Handle multiple response headers when following a redirection
786905d
Merge branch 'master' of https://github.com/bjeavons/curl
3101030
Merge branch 'master' of https://github.com/hamstar/curl
7327f41
Merge branch 'master' of https://github.com/SimpleUpdates/curl.git
b1593bb
Fixed errors caused from the merge of https://github.com/SimpleUpdate…
9cefbb5 
…s/curl.git
Added support for HTTP basic authentication
67caeda
Added ztest as submodule
f70be61
@aseba
Added debug support
5dc0822
@hamstar
added composer spec with the name shuber/curl
5962b52
Merge pull request #1 from hamstar/master
e6b1a12 
Added composer spec
@nickl-
merge with hugo chinchilla
2283a0d
@nickl-
huge refactoring: Use of getters|setters, PUT-Data-Requests
fc6eed1
@nickl-
huge refactoring: Use of getters|setters, PUT-Data-Requests
732f2bf
@nickl-
added missing require_once
accdb81
@nickl-
minor changes in curl & curl_response
d28f9ec
@nickl-
Unit tests => PHPUNIT
7b358fc
@nickl-
added SSL handling
2d3b276
@apemsel @nickl-
fix setOption() and setOptions()
9231a7b
@nickl-
gitignore
e0bcb28
@nickl-
includes
500dbd7
@nickl-
small bugfix for urls without scheme
d77556e
@nickl-
added very simple autoloader
17b27f7
@nickl-
added very simple autoloader
f00a2dd
@nickl-
test changes
cafc4ac
@nickl-
Merge contrib branch 'merge-stream'
0b2ae29 
Contribution by Sebastian Alvarez @aseba enabling CURLOPT_VERBOSE
@nickl-
Copy link

nickl- commented Jun 19, 2012

merged at nickl-/curl@8dec78d

nickl- and others added 28 commits June 19, 2012 14:35
@nickl-
Better Headers and optimizations.
3596d92 
Collect response->debug_log if debug is enabled.
Header parsing is optional by default only the response body will be returned.
If headers are chosen both request and response raw headers are kept.
Still only the response is separated and collected in associative array.
@nickl-
Merge with latest from professional-style
4155d96
@nickl-
Restructure PSR-0 compliance, and reformatting.
8595dbb 
Also added User agent composition.
@nickl-
Let the magic begin
8f2b106
@nickl-
The class file is now called Curl.php and not curl.php
cf551d3
@nickl-
Merge branch 'master' of git://github.com/jrivero/curl into merge-stream
e647ecd
@nickl-
merge changes from jrivero
f2e417f
@nickl-
Standard header values initialized
d1974aa
@nickl-
Resolve all removed references
083552b
@nickl-
PSR-1 and PSR-2 coding standard compliancy.
2261fa3
@nickl-
manual kleen fix
f29f392
@nickl-
more cs conformities
b8965ff
@nickl-
Add package descriptors
547be35
@nickl-
Added missing ref to Exception
869d397
@nickl-
Added isJson convenience method
1a7fefa
@mattleff
Anchor regex to allow headers with wildcard
ab023a5 
For example, `Access-Control-Allow-Origin:*`
@mattleff
Correct exception class
611e24b
@mattleff
Merge pull request #1 from SimpleUpdates/composer
f9a607f 
Use Composer
@mattleff
Bump version
3e021f6
@mattleff
Fix bugs; tag 1.0.2
2f45c2e
@mattleff
1.0.3 with fix for unit tests
44a19a8
@mattleff
Fixes issue with HTTP 100-Continue header
0df818d
@mattleff
Update composer.json
e4e1540
@mattleff
Only throw exception if there's an error
2de5bd1
@mattleff
Match all response headers until end of headers
3d2f30e
Remove Reason-Phrase
98613f8
Update cacert.pem
a15d7ec
Update composer.json
b1747aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@KendallHopkins @nickl- @bjeavons @hamstar @jrivero @aseba @apemsel @mattleff