Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme-configuration.mdx #2221

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Update theme-configuration.mdx #2221

merged 4 commits into from
Feb 1, 2024

Conversation

kgolubic
Copy link
Contributor

@kgolubic kgolubic commented Aug 28, 2023

Added the note about disabling the edit link.

fixes #1719
fixes #2289

Added the note about disabling the edit link.
@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2023

🦋 Changeset detected

Latest commit: 36e0c49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
nextra-theme-docs Patch
nextra Patch
nextra-theme-blog Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 3:25pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 3:25pm

@vercel
Copy link

vercel bot commented Aug 28, 2023

@kgolubic is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@arnabsen
Copy link
Contributor

hi @shuding, can we add this to the docs?

@Aruelius
Copy link

if we set editLink.text to null, the a element still render without text.

image

however if set 'editLink.component' to null, it works, but raise an error: Must be React.FC. Path: "editLink.component"

set feedback.content to null works will.

@dimaMachina dimaMachina merged commit 93b5705 into shuding:main Feb 1, 2024
6 of 8 checks passed
dimaMachina pushed a commit that referenced this pull request Feb 2, 2024
…2674)

* Showcase React Cosmos docs (#2647)

* Update theme-configuration.mdx (#2221)

* Update theme-configuration.mdx

Added the note about disabling the edit link.

* fix normalize pagemap

* a

---------

Co-authored-by: Dimitri POSTOLOV <[email protected]>

* chore(deps): update actions/cache action to v4 (#2642)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update pnpm to v8.15.1 (#2499)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update styfle/cancel-workflow-action action to v0.12.1 (#2670)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Version Packages (#2668)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* more

* aa

* prettier

* make tests pass

* prettier

* fix sort of html attributes when codeHighlight=false

---------

Co-authored-by: Ovidiu Cherecheș <[email protected]>
Co-authored-by: Kruno Golubic <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants