Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve subheading anchor visibility and color adjustments v4 #4057

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Jan 25, 2025

Why:

it's hard to click the anchor link because it only shows when you hover over an invisible button, now it shows when you hover over the title as well

this is what docusaurus and vitepress do

this also improves color contrast for better accessibility

What's being changed (if available, include any code snippets, screenshots, or gifs):

Screen.Recording.2025-01-25.at.11.35.33.PM.mp4

Check off the following:

  • I have reviewed my changes in staging, available via the View
    deployment
    link in this PR's timeline (this link will be available after
    opening the PR).

Copy link

changeset-bot bot commented Jan 25, 2025

🦋 Changeset detected

Latest commit: 0c49f56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
nextra-theme-docs Patch
nextra Patch
nextra-theme-blog Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 10:39am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 10:39am

Copy link

vercel bot commented Jan 25, 2025

@hichemfantar is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@hichemfantar hichemfantar marked this pull request as ready for review January 25, 2025 22:40
@hichemfantar hichemfantar changed the title Improve subheading anchor visibility and color adjustments Improve subheading anchor visibility and color adjustments v4 Jan 25, 2025
@dimaMachina dimaMachina merged commit 8d878dd into shuding:main Jan 28, 2025
6 of 9 checks passed
@hichemfantar hichemfantar deleted the better-anchor-style branch January 28, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants