-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to render TOC in type page #4082
Ability to render TOC in type page #4082
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@hichemfantar is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: cc29e39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with this change, but I don't see the reason to make configurable breadcrumb, since it's navigation, and for single page it doesn't make sense
Why:
this pr gives the user more control and adheres to user expectation.
implicit, undocumented, and no workaround behavior like this should be avoided.
Closes: #4081
Closes: #4030
What's being changed (if available, include any code snippets, screenshots, or gifs):
http://localhost:3000/about
before
after
docusaurus allows rendering toc on regular pages which is useful and i need this
I realize this changes previous behavior but this is needed and it's best to do it now while v4 is new and very few people are using it.
Check off the following:
deployment link in this PR's timeline (this link will be available after
opening the PR).