Fix incorrect variable ordering and test position.rs
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osition.rs` Corrected the order of `sqrt_ratio_x96_upper` and `sqrt_ratio_x96_lower` in both `mint_amounts_with_slippage` and `burn_amounts_with_slippage` methods in `position.rs`. Added a variety of tests to ensure these methods function as expected under different conditions, including min/max pool price and different position scenarios.
gnarlycow
approved these changes
Jan 8, 2024
shuhuiluo
changed the title
position.rsposition.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the order of
sqrt_ratio_x96_upperandsqrt_ratio_x96_lowerin bothmint_amounts_with_slippageandburn_amounts_with_slippagemethods inposition.rs. Added a variety of tests to ensure these methods function as expected under different conditions, including min/max pool price and different position scenarios.