-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix v
in self_permit
and add example
#120
Conversation
Introduced a new `self_permit` example to demonstrate signing ERC20 permits and encoding `selfPermit` calls for Uniswap V3. Improved encoding logic in `self_permit.rs` by adding EIP-712 signing hash functionality and fixing signature encoding with +27 adjustment. Updated version to 3.1.0 to reflect new functionality.
Caution Review failedThe pull request is closed. WalkthroughAdjusts glasses Fascinating! This pull request introduces a minor version update to the Uniswap V3 SDK, adding a new Changes
Sequence DiagramsequenceDiagram
participant Signer
participant USDC
participant NonfungiblePositionManager
Signer->>USDC: Generate Permit Signature
Signer->>NonfungiblePositionManager: Send Signed Permit
NonfungiblePositionManager-->>USDC: Verify Permit
NonfungiblePositionManager-->>Signer: Update Allowance
Possibly Related PRs
Poem
mic drop 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Introduced a new
self_permit
example to demonstrate signing ERC20 permits and encodingselfPermit
calls for Uniswap V3. Improved encoding logic inself_permit.rs
by adding EIP-712 signing hash functionality and fixing signature encoding with +27 adjustment. Updated version to 3.1.0 to reflect new functionality.Summary by CodeRabbit
New Features
uniswap-v3-sdk
to 3.1.0.self_permit
feature.Bug Fixes
encode_permit
function for better token type flexibility and corrected encoding logic for permit calls.Documentation