-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add nonfungible position manager example #122
Conversation
Introduce a new example demonstrating minting liquidity with the Uniswap Nonfungible Position Manager. Refactor transaction handling by replacing deprecated `register()` calls with `watch()` for better event monitoring. Adjust `get_erc20_state_overrides` to use provider references for improved API consistency.
WalkthroughThe pull request introduces a new example for the Uniswap V3 SDK demonstrating interaction with the Non-Fungible Position Manager. It modifies transaction handling methods in existing examples from Changes
Sequence DiagramsequenceDiagram
participant User
participant NPM as NonFungiblePositionManager
participant Blockchain
User->>NPM: Prepare Liquidity Position
NPM->>Blockchain: Mint Liquidity
Blockchain-->>NPM: Confirm Transaction
NPM-->>User: Return Position Token ID
Possibly related PRs
Poem
[Bazinga!] 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
🔇 Additional comments (8)examples/nonfungible_position_manager.rs (3)
examples/swap_router.rs (1)
examples/self_permit.rs (1)
src/extensions/state_overrides.rs (2)
Cargo.toml (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Introduce a new example demonstrating minting liquidity with the Uniswap Nonfungible Position Manager. Refactor transaction handling by replacing deprecated
register()
calls withwatch()
for better event monitoring. Adjustget_erc20_state_overrides
to use provider references for improved API consistency.Summary by CodeRabbit
Release Notes
New Features
Improvements
Code Quality