perf: refactor multicall encoding and cleanup redundant clones

[shuhuiluo]

Simplifies encoding logic in encode_multicall by reducing unnecessary clones and updates type usage for consistency. Improves readability in other modules by removing redundant .clone() calls and ensures cleaner ownership handling. Also aligns imports to address missing dependencies.

Summary by CodeRabbit

• Package Version

  • Updated Uniswap V3 SDK package version from 3.1.1 to 3.1.2

• Performance Improvements

  • Optimized code in multiple modules by removing unnecessary cloning
  • Simplified data handling in encoding and decoding functions

• Code Enhancements

  • Refined internal logic in trade, pool, and multicall implementations
  • Added vector import in state overrides module

[coderabbitai]

Walkthrough

Bazinga! A minor update to the Uniswap V3 SDK has occurred, involving precision tweaks across multiple files. The changes primarily focus on optimizing code efficiency by eliminating unnecessary cloning, updating the package version, and refining type handling in various utility functions. Fascinating, yet delightfully mundane!

Changes

File	Change Summary
Cargo.toml	Version bumped from 3.1.1 to 3.1.2
src/entities/trade.rs	Simplified swap route addition using into_iter().next().unwrap()
src/extensions/pool.rs	Removed provider cloning in pool key methods
src/extensions/state_overrides.rs	Added alloc::vec::Vec import for access list filtering
src/multicall.rs	Streamlined multicall encoding and decoding logic

Poem

Rust code dancing, lean and bright,
Clones vanish in algorithmic light
SDK version ticks up high
Efficiency soars, no need to sigh
Sheldon's logic, pure delight! 🧮✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 24ac093 and 935d593.

📒 Files selected for processing (5)

• Cargo.toml (1 hunks)
• src/entities/trade.rs (1 hunks)
• src/extensions/pool.rs (2 hunks)
• src/extensions/state_overrides.rs (1 hunks)
• src/multicall.rs (2 hunks)

🔇 Additional comments (7)

src/multicall.rs (3)

9-9: Bazinga! unwrap risk.
If data isn't guaranteed to have exactly one element, calling .unwrap() could lead to a catastrophic meltdown at runtime. Ensure the length is validated somewhere before or handle the error case.

---

11-15: Streamlined collection.
Converting data into the data field via .map(Into::into).collect() is quite elegant. Kudos.

---

97-97: Exquisite decoding clarity.
Using <Vec<Vec<u8>>>::decode_multicall makes the decoded type explicit, improving comprehensibility. Well done.

src/extensions/state_overrides.rs (1)

2-2: Greetings, fellow developer.
The import alloc::vec::Vec here presumably aids no-std compatibility. That’s thoughtful.

src/extensions/pool.rs (2)

68-68: Cloning management.
Your direct usage of provider rather than cloning is logical. Fewer clones, fewer memory allocations, more efficiency. Excellent.

---

174-174: Same pattern, improved.
Again, removing unnecessary cloning is wise. High five for optimization.

Cargo.toml (1)

3-3: Version increment.
Upgrading to 3.1.2 is a prudent measure, presumably to align with your refactoring changes.