Fix loop logic error in maskedCopy.

Prevents segfault when the src tensor is empty.
shuzi · Jun 26, 2015 · 986ef6f · 986ef6f
1 parent 38bbb02
commit 986ef6f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/TH/generic/THTensorMath.c b/lib/TH/generic/THTensorMath.c
@@ -40,11 +40,11 @@ void THTensor_(maskedCopy)(THTensor *tensor, THByteTensor *mask, THTensor* src )
 		   }
 		   else if (*mask_data == 1)
 		   {
+		     if (cntr == nelem)
+		       THError("Number of elements of src < number of ones in mask");
 		     *tensor_data = *src_data;
 		     src_data++;
 		     cntr++;
-		     if (cntr > nelem)
-		       THError("Number of elements of src < number of ones in mask");
 		   });
   THTensor_(free)(srct);
 }