Integrate Impressive Changes #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoinbaseError: [u"Price can't be blank"]
Get rid of "Price can't be blank"
price_currency_iso in button api
|
Oh look at this. Yeah. The thing is that I have never actually run this code on live coinbase, it's for an ongoing project. I wrote test cases so it should be good, and it looks like people are using it. I have no problems with integrating it, I just needed some additional features. |
… + api_secret HMAC authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very impressive work! How about we integrate them and I'll make you an author on the official package?
-George