#185 into [email protected] 🧊 add new eslint #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiceWithMeat
approved these changes
Nov 10, 2024
MiaInturi
requested changes
Nov 10, 2024
| "express-urlrewrite": "^2.0.2", | ||
| "flat": "^5.0.2", | ||
| "graphql": "^16.8.1", | ||
| "graphql": "^16.9.0", |
There was a problem hiding this comment.
У пакета graphql в package.json в свойстве engines.node написано "^12.22.0 || ^14.16.0 || ^16.0.0 || >=17.0.0" - это самое строгое свойство из всех пакетов которые мы используем. А нам, чтобы мы корректно работали, надо также указать самое строгое свойство в нашем engines.node, т.е. взять то свойство, которые у пакета graphql
There was a problem hiding this comment.
Я поставил сразу 14, что думаешь ?
There was a problem hiding this comment.
В папке bin/templates остался eslint config старого формата
There was a problem hiding this comment.
кстати я совсем забыл про template для flat нужно будет добавить
MiaInturi
reviewed
Nov 16, 2024
MiaInturi
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.