Add RSC support #23
Merged
Add RSC support #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoodPassiveMan
force-pushed
the
feat/rsc-support
branch
from
2cdceac to
1c29c32
Compare
|
Changes seems okay, the reason why the instance is initialized inside is later it could initialize with option that might be from the props. Wondering it will be needed 🤔 |
|
@sibiraj-s hey, do you think you can merge it or should I do something before it? |
|
Lets merge this, I will figure out stuffs later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use this wonderful library, but unfortunately it doesn't work with RSC. Fortunately, I fixed this by removing
useRef.Open to any discussion and suggestions.