Fix for https://github.com/wso2/streaming-integrator/issues/165 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramindu90
requested changes
Jan 10, 2021
| this.scheduledFuture = siddhiAppContext.getScheduledExecutorService(). | ||
| scheduleAtFixedRate(fileSourcePoller, 0, 1, TimeUnit.SECONDS); | ||
| } | ||
| if (isTailingEnabled && fileSourceConfiguration.getFileServerConnector() != null) { |
There was a problem hiding this comment.
If tailing disabled, and if its a large file which will take time more than the persisting interval, the file processing may stop. Isnt it?
Shall we use filePointer and resolve that issue?
This may affect for the files that will be processing in a given dir.uri as well
There was a problem hiding this comment.
Hi Ramindu,
In the existing pause() method, the file processing thread is not stopped which is the reason why I thought that there is nothing to resume in the resume() method, assuming that the file will be processed anyway. But let's check this further, to make sure that happens. I have created a separate issue to track this particular issue: #120.
Thanks
Resolves following issues in file:move(): 'include.by.regexp' and 'exclude.root.dir' parameters in file:move() are not dynamic When 'exclude.root.dir' parameter is set to true, the destination path does not get created correctly When four parameters are given, the regex is always set to ''
sajithshn
approved these changes
Feb 17, 2021
ramindu90
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improves the fix done for wso2/streaming-integrator#165 by returning false when FileSystemException occurs.
Also