Review #39
Open
Review #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangping
reviewed
Jun 5, 2023
Comment on lines
+235
to
+239
| // What if channel is not found ? | ||
| channel, _ := channelKeeper.GetChannel(ctx, msg.SourcePort, msg.SourceChannel) | ||
| // What if sequence is not found ? | ||
| // Will this sequence always be different ? Order ID duplication depends on it. | ||
| // Should we add a check for duplicate order id ? |
There was a problem hiding this comment.
seems use a random string is much reliable.
| @@ -27,6 +27,8 @@ func (k Keeper) CancelSwap(goCtx context.Context, msg *types.CancelSwapMsg) (*ty | |||
| } | |||
|
|
|||
| // Make sure the sender is the maker of the order. | |||
| // TODO: New Message logic for cancel swap is incomplete. (using command line) | |||
| // We should verify/make sure that msg.MakerAddress and sender of TX is same. Otherwise this should fail | |||
There was a problem hiding this comment.
msg.MakeAddress should be the sender in the design.
soring323
force-pushed
the
dev
branch
3 times, most recently
from
ef91bae to
7134dc7
Compare
soring323
force-pushed
the
dev
branch
17 times, most recently
from
b24e096 to
34e1dee
Compare
soring323
force-pushed
the
dev
branch
3 times, most recently
from
8757dd1 to
c09cafd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.