Major refactor of the tool #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkerj
force-pushed
the
refactor
branch
6 times, most recently
from
4151bde to
85b811a
Compare
|
Refactoring is done, shutdown/reboot from vSphere seems to work and vSphere shows correct hostname and IP-info. I think refactoring is done and it's time for a review/merge/release. |
jonkerj
force-pushed
the
refactor
branch
2 times, most recently
from
4163bd2 to
b80971b
Compare
jonkerj
force-pushed
the
refactor
branch
8 times, most recently
from
2409e1f to
7855aa6
Compare
|
All the testing is complete, even the linters are happy now. We have tested the tool in the following ways:
|
smira
approved these changes
Feb 11, 2025
I'm about to double check functionality of the tool as system-extension and as a daemonset. |
jonkerj
force-pushed
the
refactor
branch
2 times, most recently
from
54b3783 to
871c8e5
Compare
|
We are going to release this as a new major version, as flags/env vars have been renamed. |
robinelfrink
approved these changes
Feb 11, 2025
* update go mods, golang ci and k8s manifest * split the tool into subcommands, leveraging cobra/viper * refactored the logging, using a current framework (log/slog) * repair project name "self-detection" and startup message * moved reusable components into pkg/ * restricted accessibility, improved delegation/demaraction * refactor connection to Talos API (consistent naming) * refactor of toolbox command dispatching * fetch uptime from Talos, instead of system * use upstream GuestNicInfo (= less code to maintain) * fix licensing (version.go was MPL by accident), reduce header bloat * reduce talosquery subcommand complexity * update README BREAKING CHANGE: command line flags and env vars have been changed Signed-off-by: Jorik Jonker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
pkg/packageslog/slogThis should also lay the groundwork for the implementation of #25