Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sh/updates #16

Merged
merged 7 commits into from
May 11, 2023
Merged

Sh/updates #16

merged 7 commits into from
May 11, 2023

Conversation

susuhahnml
Copy link
Collaborator

No description provided.

gschennersie
gschennersie previously approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@gschennersie gschennersie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me everything looks ok and the test run without errors.

PS: Some minor point most probably unrelated to this branch: During checking your branch i also checked the Jupyter Notebooks and in usage\Configuration.ipynb and usage\Interactive.ipynb there is an error when i run the last cells at least on my computer. If you have any ideas to automatically test Notebooks let me know. We have this problem in other projects. And when visualizing configurations the classnames are in upper case (e.g. Frame) but for the kb they are in lowercase.

rtaupe
rtaupe requested changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@rtaupe rtaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Susana!
Please let's just address a minor issue regarding new terminology before merging.

asp_interactive_configuration/DOC.md Outdated Show resolved Hide resolved
asp_interactive_configuration/ooasp/encodings_simple/ooasp.lp Outdated Show resolved Hide resolved
asp_interactive_configuration/ooasp/tests/test_performance.py Outdated Show resolved Hide resolved
@susuhahnml
Copy link
Collaborator Author

All addressed in the last commit!

@rtaupe
Copy link
Collaborator

rtaupe commented May 11, 2023

All addressed in the last commit!

The place I pointed out where the old terminology is still used was just an example, there are also others. Do you want to fix them or shall I?

@susuhahnml
Copy link
Collaborator Author

I just updated the ones I could find, if you have any more in the radar, please add them :)

@rtaupe
Copy link
Collaborator

rtaupe commented May 11, 2023

Thank you!

@rtaupe rtaupe merged commit c26f7e9 into main May 11, 2023
@rtaupe rtaupe deleted the sh/updates branch May 11, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtaupe rtaupe rtaupe approved these changes

@gschennersie gschennersie gschennersie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@susuhahnml @rtaupe @gschennersie