Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logging while accessing configuration data #93

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

Akretsch
Copy link
Collaborator

Description

Log access to configuration as much as possible

Related Issue

#92

Motivation and Context

If the configuration methods return non-compliant values or generate exceptions the overall behavior of CmpRaComponent is sometimes strange.

How Has This Been Tested?

Run Unit-Test with logging enabled.

Screenshots

@Akretsch Akretsch requested a review from ralienpp February 28, 2024 15:01
@Akretsch Akretsch force-pushed the add_config_logging branch 3 times, most recently from 538bd2c to 0de2303 Compare March 6, 2024 11:08
@Akretsch Akretsch force-pushed the add_config_logging branch from 0de2303 to a451e0e Compare March 6, 2024 11:11
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
73.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@ralienpp ralienpp merged commit 48e7fec into main Mar 7, 2024
4 of 5 checks passed
@ralienpp
Copy link
Collaborator

ralienpp commented Mar 7, 2024

Coverage issues and specific exceptions will be addressed in a subsequent release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants