Skip to content

Commit

Permalink
bug fixes (#209)
Browse files Browse the repository at this point in the history
* bug fixes

* Resolve review comments

* Changed Poetry lock Dev Dependency identification logic.

* Updated to 7.0.1 in all the project files
  • Loading branch information
MalavikaKrishnan100 authored Nov 27, 2024
1 parent 48f4192 commit 1cbc34f
Show file tree
Hide file tree
Showing 11 changed files with 19 additions and 18 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/compile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
$sourceFolder = Join-Path $env:GITHUB_WORKSPACE "out" | Join-Path -ChildPath "*"
$outFolder = Join-Path $env:GITHUB_WORKSPACE "out" | Join-Path -ChildPath "continuous-clearing"
New-Item -ItemType Directory -Force -Path $outFolder
$fileName = "continuous-clearing-v7.0.0.zip"
$fileName = "continuous-clearing-v7.0.1.zip"
Write-Host "Filename: '$fileName'"
Write-Host "sourceFolder: '$sourceFolder'"
Write-Host "Outfolder: '$outFolder'"
Expand Down Expand Up @@ -129,8 +129,8 @@ jobs:
- name: Create Nuget Packages
id: createNupkg
run: |
nuget pack CA.nuspec -Version 7.0.0
Write-Host "::set-output name=nupkg-LicenseClearingTool::continuous-clearing.7.0.0.nupkg"
nuget pack CA.nuspec -Version 7.0.1
Write-Host "::set-output name=nupkg-LicenseClearingTool::continuous-clearing.7.0.1.nupkg"
- name: Archive NuGet Packages
uses: actions/upload-artifact@v4
Expand Down Expand Up @@ -164,9 +164,9 @@ jobs:
#if: ${{ false }} # disable for now
run: |
echo "Files in directory:"
docker build . --file Dockerfile --tag ${{ github.repository }}:continuous-clearing-v7.0.0
docker save ${{ github.repository }}:continuous-clearing-v7.0.0 -o continuous-clearing-v7.0.0.tar
echo "::set-output name=docker-LicenseClearingTool::continuous-clearing-v7.0.0.tar"
docker build . --file Dockerfile --tag ${{ github.repository }}:continuous-clearing-v7.0.1
docker save ${{ github.repository }}:continuous-clearing-v7.0.1 -o continuous-clearing-v7.0.1.tar
echo "::set-output name=docker-LicenseClearingTool::continuous-clearing-v7.0.1.tar"
- name: Archive docker image
#if: ${{ false }} # disable for now
Expand Down Expand Up @@ -214,8 +214,8 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: v7.0.0
release_name: Release v7.0.0
tag_name: v7.0.1
release_name: Release v7.0.1
body: |
${{ github.event.head_commit.message }}
draft: true
Expand Down
2 changes: 1 addition & 1 deletion src/ArtifactoryUploader/LCT.ArtifactoryUploader.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<AssemblyName>ArtifactoryUploader</AssemblyName>
<Version>7.0.0</Version>
<Version>7.0.1</Version>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
Expand Down
2 changes: 1 addition & 1 deletion src/LCT.APICommunications/LCT.APICommunications.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<OutputType>Library</OutputType>
<TargetFramework>net8.0</TargetFramework>
<Version>7.0.0</Version>
<Version>7.0.1</Version>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
Expand Down
2 changes: 1 addition & 1 deletion src/LCT.ArtifactPublisher/LCT.ArtifactPublisher.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<Version>7.0.0</Version>
<Version>7.0.1</Version>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
Expand Down
2 changes: 1 addition & 1 deletion src/LCT.Common/LCT.Common.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<OutputType>Library</OutputType>
<TargetFramework>net8.0</TargetFramework>
<Version>7.0.0</Version>
<Version>7.0.1</Version>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
Expand Down
2 changes: 1 addition & 1 deletion src/LCT.CycloneDxProcessor/LCT.CycloneDxProcessor.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<Version>7.0.0</Version>
<Version>7.0.1</Version>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
Expand Down
2 changes: 1 addition & 1 deletion src/LCT.Facade/LCT.Facade.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<Version>7.0.0</Version>
<Version>7.0.1</Version>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
Expand Down
2 changes: 1 addition & 1 deletion src/LCT.PackageIdentifier/LCT.PackageIdentifier.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<AssemblyName>PackageIdentifier</AssemblyName>
<Version>7.0.0</Version>
<Version>7.0.1</Version>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
Expand Down
3 changes: 2 additions & 1 deletion src/LCT.PackageIdentifier/PythonProcessor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@ private static List<PythonPackage> GetPackagesFromTOMLFile(string filePath, List
Name = node["name"].ToString(),
Version = node["version"].ToString(),
PurlID = Dataconstant.PurlCheck()["PYTHON"] + "/" + node["name"].ToString() + "@" + node["version"].ToString(),
Isdevdependent = node["category"].ToString() != "main",
// By Default Tommy.TomlLazy is coming instead of Null or empty
Isdevdependent = (node["category"].ToString() != "main" && node["category"].ToString() != "Tommy.TomlLazy"),
FoundType = Dataconstant.Discovered
};

Expand Down
2 changes: 1 addition & 1 deletion src/LCT.SW360PackageCreator/LCT.SW360PackageCreator.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<AssemblyName>SW360PackageCreator</AssemblyName>
<Version>7.0.0</Version>
<Version>7.0.1</Version>
<RootNamespace>LCT.SW360PackageCreator</RootNamespace>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion src/LCT.Services/LCT.Services.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<OutputType>Library</OutputType>
<TargetFramework>net8.0</TargetFramework>
<Version>7.0.0</Version>
<Version>7.0.1</Version>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
Expand Down

0 comments on commit 1cbc34f

Please sign in to comment.