fix(core/select-item): check by undefined not by value (#1214)

Co-authored-by: Daniel Leroux <[email protected]>
siemens · Apr 15, 2024 · 22a83d9 · 22a83d9
1 parent 34b50ef
commit 22a83d9
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/sweet-yaks-appear.md b/.changeset/sweet-yaks-appear.md
@@ -0,0 +1,5 @@
+---
+"@siemens/ix": patch
+---
+
+fix(core/select-item): check by undefined not by value
diff --git a/packages/core/src/components/select-item/select-item.tsx b/packages/core/src/components/select-item/select-item.tsx
@@ -69,7 +69,7 @@ export class SelectItem {
   }
 
   componentDidRender() {
-    if (!this.value) {
+    if (this.value === undefined || this.value === null) {
       throw Error('ix-select-item must have a `value` property');
     }
   }

diff --git a/packages/core/src/components/select/select.tsx b/packages/core/src/components/select/select.tsx
@@ -239,7 +239,11 @@ export class Select {
     this.items.forEach((item) => {
       item.selected = ids.some(
         // Check can be removed if value is type of string in future releases
-        (i) => i === (item.value ? item.value.toString() : '')
+        (i) =>
+          i ===
+          (item.value !== undefined && item.value !== null
+            ? item.value.toString()
+            : '')
       );
     });