Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(progress-bar): add guidelines #1091

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

silviowolf
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

  • Guidelines added

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

  • dev component and dev doc doesn’t exist yet
  • documentation has to be reviewed when component is developed

@silviowolf silviowolf requested a review from tokyojen February 21, 2024 10:44
@silviowolf silviowolf requested review from nuke-ellington and removed request for tokyojen February 28, 2024 10:31
@silviowolf silviowolf marked this pull request as ready for review February 28, 2024 12:45
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to link to a specific button page

@nuke-ellington nuke-ellington added this to the 2.2.0 milestone Mar 13, 2024
@danielleroux danielleroux marked this pull request as draft March 25, 2024 13:00
@danielleroux danielleroux removed this from the 2.2.0 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants