-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/menu): make behavior at breakpoint 'lg' configurable and change 'md' breakpoint menu icons #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuke-ellington
requested changes
Mar 13, 2024
packages/core/src/tests/basic-navigation/content-width/index.html
Outdated
Show resolved
Hide resolved
…l regression tests
jul-lam
changed the title
feat(core/menu): make behavior at breakpoint lg configurable
feat(core/menu): make behavior at breakpoint 'lg' configurable and change 'md' breakpoint menu icons
Mar 13, 2024
🦋 Changeset detectedLatest commit: 472a29a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nuke-ellington
approved these changes
Mar 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
By default, the menu is expanded at the “lg” breakpoint, and there is no option to alter this behavior.
GitHub Issue Number: #892
What is the new behavior?
By default, the menu is collapsed at the “lg” breakpoint, with a newly introduced parameter “expandedNavigationMenuPreferred” governing this behavior.
Does this introduce a breaking change?
To revert the new default behavior, the newly added parameter “expandedNavigationMenuPreferred” must be set to true.
Testing
Manual tests.
Other information