fix(core/application-switch-modal): add border-radius to app icon #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiashader
changed the title
nuke-ellington
added
the
pull request affects patch version
…witcher # Conflicts: # packages/react-test-app/src/preview-examples/vertical-tabs-with-avatar.tsx
🦋 Changeset detectedLatest commit: 8990c2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
danielleroux
requested changes
Mar 25, 2024
packages/core/src/tests/application/application-switch/index.html
Outdated
Show resolved
Hide resolved
packages/core/src/tests/application/application-switch/index.html
Outdated
Show resolved
Hide resolved
packages/core/src/tests/application/application-switch/index.html
Outdated
Show resolved
Hide resolved
danielleroux
previously approved these changes
Mar 27, 2024
danielleroux
previously approved these changes
Mar 27, 2024
danielleroux
changed the title
danielleroux
approved these changes
Mar 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build) was run locally and any changes were pushedyarn test) were run locally and passedyarn visual-regression) were run locally and passednpm lint) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The border-radius of the image inside the application switcher modal has not border-radius, according to figma this should have a radius of .25rem.
GitHub Issue Number: N/A
What is the new behavior?
The border-radius of the image is now .25rem.
Note: Also [IX-383] have been adapted in this ticket.
Does this introduce a breaking change?
Testing
Other information