Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toggle): fixed toggle circle with and height #1185

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

ridvandmrc
Copy link
Contributor

💡 What is the current behavior?

When I change font-size with 14px for mobile view, ix-toggle is broken.

Actually problem is that rem unit has not been using for width and height.

please use rem unit instead of px. because it is relative unit .

GitHub Issue Number: #1111

🆕 What is the new behavior?

  • Px unit replaced with rem then it is responsive

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (yarn docs)
  • 🧪 Unit tests were added/updated and pass (yarn test)
  • 📸 Visual regression tests were added/updated and pass (yarn visual-regression)
  • 🧐 Static code analysis passes (yarn lint)
  • 🏗️ Successful compilation (yarn build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Mar 22, 2024

🦋 Changeset detected

Latest commit: 70705ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux danielleroux merged commit cb46c07 into siemens:main Mar 22, 2024
9 checks passed
This was referenced Mar 22, 2024
matthiashader pushed a commit that referenced this pull request Mar 25, 2024
@danielleroux danielleroux added this to the 2.2.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants