Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blind): provided ellipsis for blind header #1186

Merged
merged 9 commits into from
Apr 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/curly-singers-complain.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@siemens/ix": patch
---

fix(core/blind): show ellipsis if text overflows
14 changes: 6 additions & 8 deletions packages/core/src/components/blind/blind.scss
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,7 @@
overflow: hidden;

.blind-header-wrapper {
display: block;
position: relative;
width: 100%;
min-height: 3rem;
height: 3rem;
overflow: hidden;
Expand All @@ -97,8 +95,7 @@
position: relative;
align-items: center;
flex-grow: 1;
flex-shrink: 0;
margin-right: 1rem;
margin-right: 0.5rem;
}

.blind-header {
Expand Down Expand Up @@ -135,15 +132,15 @@

.blind-header-title-row {
display: flex;
flex-grow: 1;
width: 100%;
overflow: hidden;
}

.blind-header-title-col {
flex-grow: 1;
flex-basis: 0;
display: inline-flex;
align-items: center;
min-width: 0;
width: calc(100% - 1rem);
overflow: hidden;
}

.blind-header-title-col:not(:first-of-type) {
Expand Down Expand Up @@ -194,6 +191,7 @@

.header-actions {
pointer-events: all;
margin-left: auto;
}
}

Expand Down
14 changes: 14 additions & 0 deletions packages/core/src/tests/blind/basic/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,20 @@
<ix-blind icon="bulb" variant="primary" label="primary" sublabel="sublabel">
<div>Primary content</div>
</ix-blind>
<ix-blind
icon="warning"
variant="warning"
label="A long asset name that does not fit to blind header"
subLabel="subLabel A long asset name that does not fit"
style="width: 300px"
>
<ix-icon-button
id="context-menu"
slot="header-actions"
ghost
icon="context-menu"
></ix-icon-button>
</ix-blind>
<script src="http://127.0.0.1:8080/scripts/e2e/load-e2e-runtime.js"></script>
</body>
</html>
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Loading