Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/date-dropdown): add disabled property #1264

Merged
merged 4 commits into from
May 8, 2024

Conversation

nuke-ellington
Copy link
Collaborator

💡 What is the current behavior?

GitHub Issue Number: #1252

🆕 What is the new behavior?

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: 41fb742

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix Minor
@siemens/ix-aggrid Patch
@siemens/ix-angular Minor
@siemens/ix-react Minor
@siemens/ix-vue Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nuke-ellington nuke-ellington marked this pull request as draft May 7, 2024 09:36
@nuke-ellington nuke-ellington marked this pull request as ready for review May 8, 2024 07:51
@danielleroux danielleroux added this to the 2.x.x milestone May 8, 2024
@danielleroux danielleroux merged commit 57fa028 into main May 8, 2024
13 checks passed
@danielleroux danielleroux deleted the feat/1252-date-dropdown-disabled branch May 8, 2024 08:17
@github-actions github-actions bot mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants