fix(core/drawer|inputgroup): fixed drawer display issue #1561
Conversation
🦋 Changeset detectedLatest commit: 43b14f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ridvandmrc
force-pushed
the
fix/1551-drawer-style-issue
branch
from
752cc62 to
87e0a0c
Compare
|
It has tested and verified with new version. <ix-drawer>
<ix-input-group>
<input type="text" value="input text" />
<span slot="input-start"><ix-icon name="about" size="16"></ix-icon></span>
</ix-input-group>
<ix-input value="test value" >
<ix-icon name="success" slot="start"></ix-icon>
</ix-input>
</ix-drawer> |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| @@ -20,17 +20,19 @@ | |||
| visibility: hidden; | |||
|
|
|||
| display: flex; | |||
| position: absolute; | |||
| position: fixed; | |||
There was a problem hiding this comment.
This is technically a breaking change. Can we do without that?
| regressionTest('input-group', async ({ page }) => { | ||
| await page.goto('drawer/input-group'); | ||
| await page.locator('ix-button').click(); | ||
| await page.waitForTimeout(2000); |
There was a problem hiding this comment.
Use waitForSelector instead
|
| el.classList.add('d-none'); | ||
| }, | ||
| }); | ||
| if (!el) { |
There was a problem hiding this comment.
Sorry to bother again, but I just realised that it might make more sense to make el not optional and move the null check to the call of the functions. What do you think?
💡 What is the current behavior?
GitHub Issue Number: #1551
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs)pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support