Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/toggle): link label and input field to be clickable #1587

Merged
merged 18 commits into from
Dec 16, 2024

Conversation

danielleroux
Copy link
Collaborator

💡 What is the current behavior?

GitHub Issue Number: closes #1585

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Nov 29, 2024

🦋 Changeset detected

Latest commit: 2376369

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label is not clickable anymore. Was that on purpose? Still shows the pointer cursor.

@danielleroux danielleroux reopened this Dec 6, 2024
AndreasBerliner
AndreasBerliner previously approved these changes Dec 9, 2024
.changeset/thin-frogs-relax.md Outdated Show resolved Hide resolved
@danielleroux danielleroux added this to the Patch Release December milestone Dec 10, 2024
@nuke-ellington nuke-ellington merged commit 0e17350 into main Dec 16, 2024
16 checks passed
@nuke-ellington nuke-ellington deleted the fix/toggle-with-disable branch December 16, 2024 09:55
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to click on toggle
3 participants