fix: select text file string should be i18n supported. avoided renaming existing field for backward compatiblity #1591
Conversation
…g existing field for backward compatiblity
|
|
ram-02
changed the title
| /** | ||
| * Label for Select file text | ||
| */ | ||
| @Prop() i18nSelectFileText = '+ Drag files here or…'; |
There was a problem hiding this comment.
What is the purpose behind this change?
There was a problem hiding this comment.
I want to pass this string as per selected language, similar to i18nUploadFile button internationalization.
Kindly let me know if any other details are needed.
There was a problem hiding this comment.
selectFileText property is getting used to show default text, Can we rename selectFileText to i18nSelectFileText instead of adding new property?
There was a problem hiding this comment.
At least not in a minor version this have to be done on a major version e.g release-3.0.0 branch.
There was a problem hiding this comment.
Ok then can you please suggest how should we proceed with this PR?
Should I close this PR and raise a defect to address this or should I follow any other steps?
There was a problem hiding this comment.
I see two options here:
Either close the PR and add the i18n prefix at a later point in time, or
deprecate the selectFileText property (and add a changeset to this PR).
💡 What is the current behavior?
GitHub Issue Number: #
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs)pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support