Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: deprecate legacy navigation frames #1597

Merged
merged 31 commits into from
Dec 12, 2024

Conversation

jul-lam
Copy link
Collaborator

@jul-lam jul-lam commented Dec 4, 2024

💡 What is the current behavior?

GitHub Issue Number: IX-1886

  • map navigation and basic navigation are not deprecated
  • the migration is not documented currently

🆕 What is the new behavior?

  • map navigation and basic navigation are deprecated now
  • the migration is now documented

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: d98c5ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jul-lam jul-lam self-assigned this Dec 4, 2024
@jul-lam jul-lam changed the title Feat/deprecate legacy navigation frames docs: deprecate legacy navigation frames Dec 4, 2024
nuke-ellington
nuke-ellington previously approved these changes Dec 9, 2024
Force sonar re-run
Copy link

@nuke-ellington nuke-ellington merged commit 7091a6e into release-3.0.0 Dec 12, 2024
13 checks passed
@nuke-ellington nuke-ellington deleted the feat/deprecate-legacy-navigation-frames branch December 12, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants