Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: integrate ix-icons v3 #1600

Open
wants to merge 31 commits into
base: release-3.0.0
Choose a base branch
from
Open

Conversation

nuke-ellington
Copy link
Collaborator

💡 What is the current behavior?

GitHub Issue Number: IX-1587

🆕 What is the new behavior?

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: dbdd087

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nuke-ellington nuke-ellington changed the base branch from main to v3-remove-bootstrap December 5, 2024 13:51
@nuke-ellington nuke-ellington changed the base branch from v3-remove-bootstrap to release-3.0.0 December 5, 2024 13:52
Copy link

sonarqubecloud bot commented Dec 5, 2024

@nuke-ellington nuke-ellington marked this pull request as draft December 9, 2024 13:14
@nuke-ellington nuke-ellington marked this pull request as ready for review January 10, 2025 10:06
BREAKING_CHANGES/v3.md Outdated Show resolved Hide resolved
BREAKING_CHANGES/v3.md Outdated Show resolved Hide resolved
BREAKING_CHANGES/v3.md Outdated Show resolved Hide resolved
BREAKING_CHANGES/v3.md Outdated Show resolved Hide resolved
packages/documentation/docs/icon-library/_icon_code.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@matthiashader matthiashader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changeset missing

matthiashader
matthiashader previously approved these changes Jan 15, 2025
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Missing component tests
  • Preview examples implemented only for angular, what happens with the other preview examples (react, vue)?
  • Changeset missing

packages/angular-test-app/src/main.ts Outdated Show resolved Hide resolved
BREAKING_CHANGES/v3.md Outdated Show resolved Hide resolved
packages/documentation/docs/icon-library/_icon_code.md Outdated Show resolved Hide resolved
packages/documentation/docs/icon-library/_icon_code.md Outdated Show resolved Hide resolved
packages/documentation/docs/icon-library/_icon_code.md Outdated Show resolved Hide resolved
@danielleroux danielleroux changed the title V3 icon docs docs: integrate ix-icons v3 Jan 31, 2025
Copy link

sonarqubecloud bot commented Feb 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants