Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(echart): align echart colors to themes #1604

Merged
merged 11 commits into from
Dec 16, 2024
Merged

Conversation

silviowolf
Copy link
Collaborator

  • update echart color configs in brand themes
  • add related theme color variables as comments

💡 What is the current behavior?

GitHub Issue Number: #

🆕 What is the new behavior?

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

- update echart color configs in brand themes
- add related theme color variables as comments
Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: d07097e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@siemens/ix-echarts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux danielleroux added this to the Patch Release December milestone Dec 10, 2024
jul-lam
jul-lam previously approved these changes Dec 16, 2024
@nuke-ellington nuke-ellington merged commit 7ef10e3 into main Dec 16, 2024
13 checks passed
@nuke-ellington nuke-ellington deleted the update-echart-colors branch December 16, 2024 09:36
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants