docs: intro sentence for date-dropdown #1605
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for industrial-experience ready!
|
tokyojen
reviewed
Dec 16, 2024
packages/documentation/docs/controls/_number-input_styleguide.mdx
Outdated
Show resolved
Hide resolved
tokyojen
reviewed
Dec 16, 2024
tokyojen
reviewed
Dec 16, 2024
packages/documentation/docs/controls/buttons/_toggle-button_styleguide.md
Outdated
Show resolved
Hide resolved
tokyojen
reviewed
Dec 16, 2024
| <br /> | ||
| <br /> | ||
| <!-- introduction start --> | ||
| Checkboxes are form controls that allow users to select no, one or more options. |
There was a problem hiding this comment.
Suggested change
| Checkboxes are form controls that allow users to select no, one or more options. | |
| Checkboxes are form controls that allow users to select none, one or more options. |
tokyojen
reviewed
Dec 16, 2024
| @@ -5,6 +5,10 @@ import Playground from '@site/src/components/PlaygroundV3'; | |||
|
|
|||
| # Drawer | |||
|
|
|||
| <!-- introduction start --> | |||
| Drawers are containers that open on click on a button to show additional content. | |||
There was a problem hiding this comment.
Suggested change
| Drawers are containers that open on click on a button to show additional content. | |
| Drawers are containers that open on the click of a button to show additional content. |
tokyojen
reviewed
Dec 16, 2024
| @@ -8,6 +8,10 @@ import Playground from '@site/src/components/PlaygroundV3'; | |||
|
|
|||
| # Event list | |||
|
|
|||
| <!-- introduction start --> | |||
| Event lists display a list of any type of elements with additional details. | |||
There was a problem hiding this comment.
Suggested change
| Event lists display a list of any type of elements with additional details. | |
| Event lists display a list of any type of element with additional details. |
tokyojen
reviewed
Dec 16, 2024
| @@ -5,6 +5,10 @@ import Playground from '@site/src/components/PlaygroundV3'; | |||
|
|
|||
| # Expanding search | |||
|
|
|||
| <!-- introduction start --> | |||
| Expanding searches are search fields that expand on click to save space. | |||
There was a problem hiding this comment.
Suggested change
| Expanding searches are search fields that expand on click to save space. | |
| Expanding searches are search fields that expand when clicked to save space. |
tokyojen
reviewed
Dec 16, 2024
| @@ -5,6 +5,10 @@ import Playground from '@site/src/components/PlaygroundV3'; | |||
|
|
|||
| # Flip | |||
|
|
|||
| <!-- introduction start --> | |||
| Flips are containers that flip on click to reveal additional content. | |||
There was a problem hiding this comment.
Suggested change
| Flips are containers that flip on click to reveal additional content. | |
| Flips are containers that flip when clicked to reveal additional content. |
tokyojen
reviewed
Dec 16, 2024
| @@ -5,6 +5,10 @@ import Playground from '@site/src/components/PlaygroundV3'; | |||
|
|
|||
| # Message bar | |||
|
|
|||
| <!-- introduction start --> | |||
| Message bars display important information to users, e.g. feedback, warnings, or errors. | |||
There was a problem hiding this comment.
Suggested change
| Message bars display important information to users, e.g. feedback, warnings, or errors. | |
| Message bars display important information to users, e.g. feedback, warnings or errors. |
tokyojen
reviewed
Dec 16, 2024
| @@ -7,6 +7,9 @@ import Playground from '@site/src/components/PlaygroundV3'; | |||
| # Pagination | |||
|
|
|||
| <Tags /> | |||
| <!-- introduction start --> | |||
| Paginations allow users to navigate between pages of content when it is split for performance reasons. | |||
There was a problem hiding this comment.
Suggested change
| Paginations allow users to navigate between pages of content when it is split for performance reasons. | |
| Paginations allow users to navigate between pages of content when it's split for performance reasons. |
tokyojen
reviewed
Dec 16, 2024
| @@ -4,7 +4,9 @@ import Events from './../auto-generated/ix-spinner/events.md'; | |||
| import Playground from '@site/src/components/PlaygroundV3'; | |||
|
|
|||
| # Spinner | |||
|
|
|||
| <!-- introduction start --> | |||
| Spinners indicate that a process is running, to provide feedback to the user. | |||
There was a problem hiding this comment.
Suggested change
| Spinners indicate that a process is running, to provide feedback to the user. | |
| Spinners indicate that a process is running to provide feedback to the user. |
tokyojen
reviewed
Dec 16, 2024
| @@ -8,7 +8,9 @@ import Playground from '@site/src/components/PlaygroundV3' | |||
| # Tooltip | |||
|
|
|||
| <Tags /> | |||
|
|
|||
| <!-- introduction start --> | |||
| Tooltips provide additional information when users hover over or focus an element. | |||
There was a problem hiding this comment.
Suggested change
| Tooltips provide additional information when users hover over or focus an element. | |
| Tooltips provide additional information when users hover over or focus on an element. |
tokyojen
reviewed
Dec 16, 2024
| @@ -5,6 +5,10 @@ import Playground from '@site/src/components/PlaygroundV3'; | |||
|
|
|||
| # Upload | |||
|
|
|||
| <!-- introduction start --> | |||
| Uploads allow users to select and upload files from their device by drag-and-drop. | |||
There was a problem hiding this comment.
Suggested change
| Uploads allow users to select and upload files from their device by drag-and-drop. | |
| Uploads allow users to select and upload files from their device via drag-and-drop. |
tokyojen
reviewed
Dec 16, 2024
| @@ -5,6 +5,10 @@ import Playground from '@site/src/components/PlaygroundV3'; | |||
|
|
|||
| # Toggle | |||
|
|
|||
| <!-- introduction start --> | |||
| Toggles (switches) enable users to toggle between an on and off state. | |||
There was a problem hiding this comment.
Suggested change
| Toggles (switches) enable users to toggle between an on and off state. | |
| Toggle switches enable users to toggle between an on and off state. |
tokyojen
reviewed
Dec 16, 2024
| @@ -11,6 +11,10 @@ import Playground from '@site/src/components/PlaygroundV3'; | |||
|
|
|||
| # Modal | |||
|
|
|||
| <!-- introduction start --> | |||
| Modals present information prominently and are useful to gather essential user input without navigating to another page. | |||
There was a problem hiding this comment.
Suggested change
| Modals present information prominently and are useful to gather essential user input without navigating to another page. | |
| Modals present information prominently and are useful for gathering essential user input without navigating to another page. |
tokyojen
reviewed
Dec 16, 2024
tokyojen
reviewed
Dec 16, 2024
packages/documentation/docs/controls/_forms-checkbox_styleguide.md
Outdated
Show resolved
Hide resolved
tokyojen
reviewed
Dec 16, 2024
packages/documentation/docs/controls/_textarea-field_styleguide.mdx
Outdated
Show resolved
Hide resolved
tokyojen
reviewed
Dec 16, 2024
tokyojen
reviewed
Dec 16, 2024
tokyojen
reviewed
Dec 16, 2024
tokyojen
reviewed
Dec 16, 2024
packages/documentation/docs/controls/application-frame/map-navigation.md
Outdated
Show resolved
Hide resolved
tokyojen
reviewed
Dec 16, 2024
tokyojen
reviewed
Dec 16, 2024
tokyojen
reviewed
Dec 16, 2024
tokyojen
reviewed
Dec 16, 2024
| @@ -4,7 +4,9 @@ import Props from './../auto-generated/ix-kpi/props.md'; | |||
| import Playground from '@site/src/components/PlaygroundV3'; | |||
|
|
|||
| # KPI | |||
|
|
|||
| <!-- introduction start --> | |||
| KPIs display measured values together with a status to help the user make better decisions. | |||
There was a problem hiding this comment.
Suggested change
| KPIs display measured values together with a status to help the user make better decisions. | |
| KPIs display measured values together with a status indicator to help users interpret data. |
tokyojen
reviewed
Dec 16, 2024
| ECharts offers a wide variety of different chart types and features. Following page deals with some more special chart types and chart features, which might become handy in some use cases. | ||
|
|
||
| <!-- introduction start --> | ||
| ECharts offers a wide variety of different chart types and features, including interacting with charts that users need in some use cases. |
There was a problem hiding this comment.
Suggested change
| ECharts offers a wide variety of different chart types and features, including interacting with charts that users need in some use cases. | |
| ECharts offers a wide variety of different chart types and features for enhanced visualization and charting. |
tokyojen
requested changes
Dec 16, 2024
Co-authored-by: tokyojen <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 What is the current behavior?
no intro sentence for date dropdown
🆕 What is the new behavior?
new intro sentence for date dropdown
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs)pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support