Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/application): application full height #1613

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

jul-lam
Copy link
Collaborator

@jul-lam jul-lam commented Dec 10, 2024

💡 What is the current behavior?

GitHub Issue Number: IX-1611 | #923 (already closed)

🆕 What is the new behavior?

  • ix-application component now utilizes full view height and width

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: 0105547

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix Major
@siemens/ix-aggrid Patch
@siemens/ix-angular Major
@siemens/ix-react Major
@siemens/ix-vue Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jul-lam jul-lam self-assigned this Dec 10, 2024
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of CSS selectors that become obsolete. Search test apps for ix-application { to spot them :)

@nuke-ellington nuke-ellington merged commit b3846c9 into release-3.0.0 Dec 11, 2024
16 checks passed
@nuke-ellington nuke-ellington deleted the feat/application-full-height branch December 11, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants