Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aggrid): define typography in ag-theme-ix #1624

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

jul-lam
Copy link
Collaborator

@jul-lam jul-lam commented Dec 16, 2024

💡 What is the current behavior?

GitHub Issue Number: xxx

  • The typography was not defined universal for ag-theme-ix, because of that certain environments rendered parts of the grid differently.

🆕 What is the new behavior?

  • The typography is now defined universal.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 4c8723a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@siemens/ix-aggrid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jul-lam jul-lam self-assigned this Dec 16, 2024
@jul-lam jul-lam closed this Dec 16, 2024
@jul-lam jul-lam reopened this Dec 17, 2024
@jul-lam jul-lam changed the title test: adapt aggrid visual-regression to new version fix(aggrid): define typography in ag-theme-ix Dec 17, 2024
@nuke-ellington nuke-ellington merged commit b016f93 into main Dec 17, 2024
13 checks passed
@nuke-ellington nuke-ellington deleted the test/aggrid branch December 17, 2024 13:49
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants