Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation playground react #1629

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

AndreasBerliner
Copy link
Collaborator

@AndreasBerliner AndreasBerliner commented Dec 18, 2024

💡 What is the current behavior?

Documentation:

  • The React code examples do not include CSS files.
  • The React StackBlitz examples do not work as a consequence of the previous issue.
  • The document: 'Forms -> Validation -> Development' is missing CSS files.

GitHub Issue Number: N/A

🆕 What is the new behavior?

Documentation:

  • The React code examples include the CSS files.
  • The React StackBlitz examples do not show an error due to missing CSS files anymore.
  • The document: 'Forms -> Validation -> Development' includes the CSS files for Angular, React and Vue.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 32c4a7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AndreasBerliner AndreasBerliner marked this pull request as ready for review December 18, 2024 10:10
@nuke-ellington nuke-ellington merged commit e31311a into main Dec 18, 2024
13 checks passed
@nuke-ellington nuke-ellington deleted the fix-documentation-playground-react branch December 18, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants