-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/select): editable select not opening #840
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiashader
changed the title
feat(bug/select): removed ref
feat(bug/select): editable select not opening
Oct 11, 2023
matthiashader
force-pushed
the
bug/select
branch
from
October 16, 2023 09:41
04b84fd
to
6c28109
Compare
danielleroux
added
the
pull request affects minor version
The pull request affects only minor version
label
Oct 20, 2023
danielleroux
changed the title
feat(bug/select): editable select not opening
fix(core/select): editable select not opening
Oct 24, 2023
Fixed in #784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
the dropdown is not opening
-> open the dropdown by the button on the right side
the list is not filtered
if the dropdown is open before editing the text, the list got filtered as expected
the focus does not work on tab --> Dropdown not showing up
GitHub Issue Number: Editable select is not opening when selecting it #832 , [ix-select] When tabbing into an ix-select, the dropdown options don't show up #773
What is the new behavior?
dropdown-list opens when clicking on the ix-select (e.g. enabled by a property)
filtering works if the list is opened with the button
Dropdown opens when using tab
Does this introduce a breaking change?
Testing
Other information