Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/select): editable select not opening #840

Closed
wants to merge 13 commits into from
Closed

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Oct 11, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

  • dropdown-list opens when clicking on the ix-select (e.g. enabled by a property)

  • filtering works if the list is opened with the button

  • Dropdown opens when using tab

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@matthiashader matthiashader changed the title feat(bug/select): removed ref feat(bug/select): editable select not opening Oct 11, 2023
@matthiashader matthiashader linked an issue Oct 12, 2023 that may be closed by this pull request
@matthiashader matthiashader marked this pull request as draft October 17, 2023 08:16
@matthiashader matthiashader marked this pull request as ready for review October 18, 2023 07:40
@matthiashader matthiashader marked this pull request as draft October 18, 2023 07:44
@matthiashader matthiashader marked this pull request as ready for review October 18, 2023 08:18
@matthiashader matthiashader marked this pull request as draft October 18, 2023 11:28
@danielleroux danielleroux added this to the 2.1.0 milestone Oct 20, 2023
@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Oct 20, 2023
@matthiashader matthiashader marked this pull request as ready for review October 24, 2023 06:47
@danielleroux danielleroux changed the title feat(bug/select): editable select not opening fix(core/select): editable select not opening Oct 24, 2023
@nuke-ellington
Copy link
Collaborator

Fixed in #784

@danielleroux danielleroux modified the milestones: 2.1.0, 2.0.4 Nov 6, 2023
@danielleroux danielleroux deleted the bug/select branch September 5, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editable select is not opening when selecting it
3 participants