Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): introduce initial GitHub actions workflow #2

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

spike-rabbit
Copy link
Collaborator

A simple workflow that lints, tests, build and optionally release based on semantic release.

Does almost all the changes requested in #1 except for including versions in the downloadable artifact.

Currently, the artifacts are just references to the tag of the release. If we decide that we must have the artifacts with versions, we
need put extra configuration and generate a zip file on our own which would consume extra space.
Therefore I am against doing this.

The npm packages will contain the version as those are updated by semantic release.

@spike-rabbit spike-rabbit self-assigned this Dec 20, 2024
@timowolf timowolf mentioned this pull request Dec 23, 2024
@spike-rabbit spike-rabbit force-pushed the build/add-ci branch 3 times, most recently from c5bdc76 to 597c18a Compare December 23, 2024 11:32
Copy link
Member

@timowolf timowolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let us get a candidate out.

@timowolf
Copy link
Member

@spike-rabbit Update the commit message.

A simple release workflow that releases using semantic release.
@timowolf timowolf merged commit f5e70be into siemens:next Dec 23, 2024
2 checks passed
Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants