Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kernel driver crash of icssg_prueth driver upon module removal #445

Conversation

nhahnetsrot
Copy link

Fixes the crash reported in #427 .

Allows now the removal / reload of the driver, network devices, links etc. are restored and working.

…ile ethernet connection is active

Signed-off-by: Torsten Hahn <[email protected]>
@nhahnetsrot nhahnetsrot force-pushed the FIX_427_iccsg_prueth_rmmod_crash branch from 6473bee to 18656ff Compare May 24, 2023 07:52
@jan-kiszka
Copy link
Collaborator

Thanks for looking into that! Still, it looks like there are still some todos remaining:

  • resolve the open questions on the fixing patch itself - we really need to understand the issue when trying to fix it
  • write the kernel patch like the patch adding it: subject, commit message, signed-off

Keep in mind that, mid-term, we would like to get rid of the patch again by sharing our findings with TI and making them adopt them, directly or at least logically. Also for them, we need to explain why we did those changes based on the code, not just the observed stability improvement.

@nhahnetsrot
Copy link
Author

Thanks for looking into that! Still, it looks like there are still some todos remaining:

  • resolve the open questions on the fixing patch itself - we really need to understand the issue when trying to fix it
  • write the kernel patch like the patch adding it: subject, commit message, signed-off

Keep in mind that, mid-term, we would like to get rid of the patch again by sharing our findings with TI and making them adopt them, directly or at least logically. Also for them, we need to explain why we did those changes based on the code, not just the observed stability improvement.

TI already knows about this bug ( i emailed with Danish Anwar [email protected], he ist responsible for the driver at TI side). He stated that a "cleaned up" version of the driver does not has this issue and will be going into the official kernel "soon". Then this patch is no longer required.
(he did not define "soon" ...)

@jan-kiszka
Copy link
Collaborator

Will we get an update? Or will this bug have to wait for replacing the patches with their upstream versions?

@jan-kiszka
Copy link
Collaborator

Obsoleted by #491

@jan-kiszka jan-kiszka closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants