Add support for AI/DI/Customized module #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaochengSu
reviewed
Jul 12, 2024
BaochengSu
reviewed
Jul 12, 2024
recipes-bsp/u-boot/files/0013-iot2050-add-smbios-and-sysinfo-support.patch
Outdated
Show resolved
Hide resolved
BaochengSu
reviewed
Jul 12, 2024
recipes-app/iot2050-conf-webui/files/src/lib/uiString/SM1223.json
Outdated
Show resolved
Hide resolved
BaochengSu
reviewed
Jul 12, 2024
...-app/iot2050-conf-webui/files/src/components/ExtendedModules/SM1221_8DI/SM1221with8DIConf.js
Outdated
Show resolved
Hide resolved
BaochengSu
reviewed
Jul 12, 2024
huaqianli
changed the title
jan-kiszka
reviewed
Jul 12, 2024
| + | ||
| t->sku_number = smbios_add_prop(ctx, "sku"); | ||
| t->family = smbios_add_prop(ctx, "family"); | ||
|
|
There was a problem hiding this comment.
This is a must for upstream-first: We can't risk introducing this interface to our board and then being rejected with the generic change by upstream later.
jan-kiszka
reviewed
Jul 12, 2024
| From: Li Hua Qian <[email protected]> | ||
| Date: Thu, 20 Jun 2024 15:32:37 +0800 | ||
| Subject: [PATCH] iot2050: add smbios and sysinfo support | ||
|
|
There was a problem hiding this comment.
Missing commit message.
jan-kiszka
reviewed
Jul 12, 2024
| - u8 padding[3]; | ||
| - u32 ddr_size_mb; | ||
| -} __packed; | ||
| +#include "../../../../drivers/sysinfo/iot2050.h" |
There was a problem hiding this comment.
This looks not so nice. Not sure if this relative include deep into the driver is acceptable. I rather suspect the header needs to move to include/.
jan-kiszka
reviewed
Jul 12, 2024
| +config SPL_SYSINFO | ||
| + bool "Support sysinfo drivers" | ||
| + help | ||
| + Enable support for sysinfo drivers in SPL. |
There was a problem hiding this comment.
This likely needs to factored out into a separate commit, along with the reason why we need sysinfo already in SPL.
jan-kiszka
reviewed
Jul 12, 2024
...rnel/linux/files/patches-6.1/0097-arm64-dts-ti-iot2050-Disable-lock-step-for-all-iot20.patch
Show resolved
Hide resolved
huaqianli
changed the title
This reverts commit 6b0ba59. This modification will cause the file descriptor to leak, and then cause the mraa process to work abnormally. Signed-off-by: Li Hua Qian <[email protected]>
This reverts commit 10cd525. This modification will cause the file descriptor to leak, and then cause the mraa process to work abnormally. Signed-off-by: Li Hua Qian <[email protected]>
This reverts commit b723c95. This modification will cause the file descriptor to leak, and then cause the mraa process to work abnormally. Signed-off-by: Li Hua Qian <[email protected]>
This reverts commit dfd245d. This modification will cause the file descriptor to leak, and then cause the mraa process to work abnormally. Signed-off-by: Li Hua Qian <[email protected]>
This module does not have any configuration entries, except which slot the module is in. Signed-off-by: Baocheng Su <[email protected]> Signed-off-by: Li Hua Qian <[email protected]>
This module does not have any configuration entries, except which slot the module is in. Signed-off-by: Baocheng Su <[email protected]> Signed-off-by: Li Hua Qian <[email protected]>
BaochengSu
reviewed
Jul 29, 2024
.../iot2050-conf-webui/files/src/components/ExtendedModules/SM1223/SM1223_AC_DI8_DQ8RLY_Conf.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Li Hua Qian <[email protected]>
Signed-off-by: Li Hua Qian <[email protected]>
Signed-off-by: Li Hua Qian <[email protected]>
Signed-off-by: Li Hua Qian <[email protected]>
Signed-off-by: Nian Gao <[email protected]> Signed-off-by: Li Hua Qian <[email protected]>
Signed-off-by: Nian Gao <[email protected]> Signed-off-by: Baocheng Su <[email protected]> Signed-off-by: Li Hua Qian <[email protected]>
The patch in question was not properly generated. Signed-off-by: Li Hua Qian <[email protected]>
This reverts commit e64ba7f. This change needs to be reversed because our Debian version does not satisfy the minimum version requirement for Node.js regarding package locking. Our project does not utilize the function associated with this vulnerability, so it should not pose an issue for us. Signed-off-by: Li Hua Qian <[email protected]>
The '-f', '--force', '-n', '--no-backup', and '-d', '--backup-dir' options are now part of a mutually exclusive group, ensuring that they cannot be used together. Having a default backup dir for -d is not reasonable for force update, and cites an abnormal case where the force update option would not work correctly. However, it's still necessary for normal update. Signed-off-by: Li Hua Qian <[email protected]>
Signed-off-by: Li Hua Qian <[email protected]>
|
LGTM |
BaochengSu
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iot2050-eio-manager: Correct the firmware update typo
iot2050-firmware-update: Correct parameter definition
Revert "build(deps): bump next in /recipes-app/iot2050-conf-webui/files"
linux-iot2050: Generate patch correctly
iot2050-conf-webui: Add support for sm1223 dc di16 dq16 rly
iot2050-eio-manager: Add support for sm1223 dc di16 dq16 rly
iot2050-conf-webui: Add support for sm1221 8di module
iot2050-eio-manager: Add support for sm1221 8di module
iot2050-conf-webui: Add support for sm1231 4AI module
iot2050-eio-manager: Add support for sm1231 4AI module
iot2050-conf-webui: Add support for module SM SENS DI
iot2050-eio-manager: Add support for module SM SENS DI
Revert "board-bootup: setup pwm pins during boot"
Revert "mraa: fix non-root access"
Revert "kas: add iot2050 user to the example image"
Revert "mraa: fix pinmux of user pin"