Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary workaround for the reboot issues #564

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

huaqianli
Copy link
Collaborator

@huaqianli huaqianli commented Oct 22, 2024

  1. u-boot-iot2050: Add temporary workaround for the QSPI issue:
    After approximately 2 months of operation, the device may fail to check
    the QSPI idle status. Here is the strange phenomenon: The QSPI remains
    busy when checking the idle status, becoming idle once stop checking.
    Providing a temporary workaround to bypass the QSPI idle checking.

  2. u-boot-iot2050: Reset the eMMC when it isn't reachable:
    After approximately 2 months of operation with above workaround, the device
    may fail to detect the eMMC when rebooting. Providing a temporary workaround
    to reset the eMMC if detection issues occur.

Related to #440.

@huaqianli huaqianli requested a review from BaochengSu October 22, 2024 02:13
@huaqianli huaqianli force-pushed the lee/upstream-qspi-workaround branch from 126ea5e to 8c63326 Compare October 22, 2024 02:19
+ mmc = find_mmc_device(i);
+ if (mmc && !mmc_init(mmc)) {
+ mmc_available = 1;
+ printf("Lee: mmc %d is availbe!\n", i);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather a debug left-over 😉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary workaround, so I want to have this log for potential debugging.

After approximately 2 months of operation, the device may fail to check
the QSPI idle status. Here is the strange phenomenon: The QSPI remains
busy when checking the idle status, becoming idle once stop checking.
This commit provides a temporary workaround to bypass the QSPI idle
checking.

TODO: Implement a permanent solution for QSPI idle checking issue.

Related to #440.

Signed-off-by: Li Hua Qian <[email protected]>
@huaqianli huaqianli force-pushed the lee/upstream-qspi-workaround branch from 8c63326 to ce45f46 Compare October 22, 2024 05:45
After approximately 2 months of operation, the device may fail to detect
the eMMC when rebooting. This commit provides a temporary workaround to
reset the eMMC if detection issues occur.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this issue likely related to how the board is wiring the eMMC, or is this a generic problem that should be addressed at eMMC driver level in U-Boot?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"For backward compatibility reason, RST_n signal is temporary disabled in device by default." - eMMC standard.

Therefore, this feature is not mandatory. If the workaround proves effective, we'll consider incorporating it into the eMMC driver.

After approximately 2 months of operation, the device may fail to detect
the eMMC when rebooting. This commit provides a temporary workaround to
reset the eMMC if detection issues occur.

TODO: Implement a permanent solution for eMMC detection issues.

Related to #440.

Signed-off-by: Li Hua Qian <[email protected]>
@huaqianli huaqianli force-pushed the lee/upstream-qspi-workaround branch from ce45f46 to 84dc8df Compare October 22, 2024 05:56
@BaochengSu
Copy link
Collaborator

Approved since this need customer side debugging info, let's have a final version after getting any feedback.

@huaqianli huaqianli merged commit 86d80f3 into master Oct 23, 2024
4 checks passed
@huaqianli huaqianli deleted the lee/upstream-qspi-workaround branch October 23, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants