Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for changes to systemd dropins #340

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

chombourger
Copy link
Collaborator

No description provided.

@chombourger chombourger added check and removed check labels Sep 26, 2023
determine if changes to systemd dropins are necessary when changes
to /etc/mtda/config are detected and whether to reload systemd.

Signed-off-by: Cedric Hombourger <[email protected]>
@chombourger
Copy link
Collaborator Author

@fmoessbauer proposing these changes to only restart systemd when we need to
thoughts?

@fmoessbauer
Copy link
Member

I had exactly the same idea, but was afraid of the implementation effort (especially as we need to ignore the file timestamps). But your solution looks clean and straight forward.

While we are at this: Currently, pure dropin-style based configuration is not supported, as mtda always wants to have a config file in /etc/mtda/config. This could be fixed in this overhaul as well. Also, our own dropins should be prefixed with a number (e.g. 10-www.conf), so users can easily override this, by using files starting at e.g. 90-<...>.conf.

@chombourger
Copy link
Collaborator Author

thank you @fmoessbauer for the feedback. I have raised #341 and #342 to address them (I usually like to make baby steps). I will probably start with #342

I am not sure I fully understand #341 just yet

@chombourger chombourger merged commit 8107923 into siemens:master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants