Performance improvements #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cuts the initial MTDA startup time in half by avoiding the creation of a huge replacement table for string ASCII encoding. Instead, we use the encode infrastructure directly (which is also more efficient on the replacement itself). Note, that this is technically not a 1:1 replacement, as non-printable characters are replaced by a '?' instead of a '.'. However, as this is anyways only used in the debug output, we believe it is a reasonable tradeoff. Signed-off-by: Felix Moessbauer <[email protected]>
The pycache is not portable and also leaks information about the build host. Signed-off-by: Felix Moessbauer <[email protected]>
chombourger
approved these changes
Oct 22, 2023
|
Looks like the CI error is unrelated. Can you retry? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.