-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: fix storage_update API #368
Conversation
mtda/client.py
Outdated
impl = self._impl | ||
session = self._session | ||
|
||
file = ImageLocal(path, impl, session, blksz, callback) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am adding ImageFile.new()
with #369
if used here, it will let us storage update
a file which is either local or remote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I will change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you. I have merged #369. you should be able to rebase your work
mtda/client.py
Outdated
|
||
try: | ||
# Prepare for download/copy | ||
file.prepare(imgsize) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with #369, prepare()
can be told the compression format to use
(file.prepare(imgsize, compression=CONSTS.IMAGE.RAW.value)
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I will change.
e6c1860
to
5cf1586
Compare
Refined the code. |
acddbf1
to
97e3226
Compare
mtda/client.py
Outdated
# It also prevents us from loading a new bmap file while | ||
# another transfer may be on-going |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this portion of the comment is not relevant (bmap files are only used with storage write
)
Changes look good. just one comment needs to be updated |
Signed-off-by: Ding Meng <[email protected]>
97e3226
to
f2516c0
Compare
changed |
@DingMeng-Siemens great work! @chombourger thanks for merging |
The storage_update need to change since the _storage_write is removed.
to solve issue #366
cc @chombourger @bovi