power/gpio: Allow to configure low level triggered relays #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chombourger
reviewed
Feb 26, 2024
mtda/power/gpio.py
Outdated
Comment on lines
37
to
43
| if 'enable' in conf: | ||
| if conf['enable'] == 'high': | ||
| self.trigger = self.HIGH | ||
| elif conf['enable'] == 'low': | ||
| self.trigger = self.LOW | ||
| else: | ||
| raise ValueError("'enable' shall be either 'high' or 'low'!") |
There was a problem hiding this comment.
is it just the GitHub interface leading me to believe that hard tabs where used here instead of soft tabs (4 spaces)?
There was a problem hiding this comment.
Yes you are right. Fixed the indentation. Thanks!
|
another very welcomed change/improvement. thanks! |
Introduce an optional `enable` config key for the power gpio. This config defaults to `high` for high level triggered relays but can be set to `low` for low level triggered relays. Signed-off-by: Tobias Schaffner <[email protected]>
TobiasSchaffner
force-pushed
the
tobsch/allow-to-use-low-level-triggered-relays
branch
from
5084750 to
f9e15d5
Compare
chombourger
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an optional
enableconfig key for the power gpio. This config defaults tohighfor high level triggered relays but can be set tolowfor low level triggered relays.