feat(www): Enable the usage of modifier keys #408
Conversation
|
was traveling this week. I will now take a look, thanks! |
|
your changes passed the emacs test!
let's get the flake8 errors and we will be good to merge this thank you @TobiasSchaffner ! |
Expose a press function in the keyboard controller that handles the press of a single key with modifier keys. The write function uses this function multiple times to send a sequence of characters. Signed-off-by: Tobias Schaffner <[email protected]>
Send the modifier keys (ctrl, shift, alt, meta) together with the send key. This allows for example allows to hit crtl-c. Signed-off-by: Tobias Schaffner <[email protected]>
Signed-off-by: Tobias Schaffner <[email protected]>
TobiasSchaffner
force-pushed
the
tobsch/keyboard-send-modifier-keys
branch
from
7531f84 to
af970b9
Compare
Great thanks @chombourger. I changed the maximum line length to 120 chars with an additional commit. Do you prefer to stick to the 80 characters? |
I’m fine with this, I always found this 80 char max rule silly |
Expose a press function in the keyboard controller that handles the press of a single key with modifier keys. Use this function from the web UI to allow to hit key combinations like ctrl-c.
Can please somebody test this with qemu? I do not have a running qemu setup atm.