fix(disable-row): allow disabling through side effects without mutati…

…ng row data (#40)
siemens · Feb 4, 2024 · d0b08c8 · d0b08c8
1 parent 91dec3d
commit d0b08c8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/projects/ngx-datatable/src/lib/components/body/body-row-wrapper.component.ts b/projects/ngx-datatable/src/lib/components/body/body-row-wrapper.component.ts
@@ -110,13 +110,14 @@ export class DataTableRowWrapperComponent implements DoCheck, OnInit {
   }
 
   ngDoCheck(): void {
+    if (this.disableCheck) {
+      const isRowDisabled = this.disableCheck(this.row);
+      this.disable$.next(isRowDisabled);
+      this.cd.markForCheck();
+    }
     if (this.rowDiffer.diff(this.row)) {
       this.rowContext.row = this.row;
       this.groupContext.group = this.row;
-      if (this.disableCheck) {
-        const isRowDisabled = this.disableCheck(this.row);
-        this.disable$.next(isRowDisabled);
-      }
       this.cd.markForCheck();
     }
   }

diff --git a/projects/ngx-datatable/src/lib/components/datatable.component.ts b/projects/ngx-datatable/src/lib/components/datatable.component.ts
@@ -829,7 +829,7 @@ export class DatatableComponent implements OnInit, DoCheck, AfterViewInit, After
    * Lifecycle hook that is called when Angular dirty checks a directive.
    */
   ngDoCheck(): void {
-    if (this.rowDiffer.diff(this.rows)) {
+    if (this.rowDiffer.diff(this.rows) || this.disableRowCheck) {
       if (!this.externalSorting) {
         this.sortInternalRows();
       } else {