fix: apply even/odd classes correctly when rows are grouped #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spike-rabbit
force-pushed
the
refactor/improve-rowindex-types
branch
from
e62e202 to
c15be94
Compare
timowolf
reviewed
Nov 8, 2024
| return this.rowIndex; | ||
| } | ||
|
|
||
| const [, innerIndex] = this.rowIndex.match(/\d+-(\d+)/); |
There was a problem hiding this comment.
Would it make sense to not use a string as a group - group item index but use two entries in a structure like groupIndex and rowIndex. I do not like the regex approach here.
There was a problem hiding this comment.
not using a string will be a breaking change as we emit this type. While I would love to do this, I think we should wait and first just have the types.
| * Represents the index of row. Usually a number. | ||
| * If the Row is grouped it returns a string with this pattern: `<indexOfGroup>-<indexOfRowInGroup>` | ||
| */ | ||
| export type RowIndex = number | `${number}-${number}`; |
There was a problem hiding this comment.
Do we need to use a string? I would prefer to have a composite here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
When using groups, all rows are marked as
oddWhat is the new behavior?
When using groups, all rows are marked as
event/oddtoggling in their group. So, the first element in a group will always beeven.Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: